Improve clarity in ProcessItem conversion logic #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it is easier to understand what's going on in the From logic for ProcessItem if the tuple fields have named values. Alternatively, we could consider to convert this to a struct. I personally would prefer that, but it's definitely a matter of preference and I don't have a strong opinion on it. ;)
kkharji
approved these changes
May 20, 2025
Owner
|
Indeed you're right a struct is much better for readability and later expansion (although no idea now how it can be expanded) |
Contributor
Author
|
I thought about this for a little longer and I actually think it's okay to keep it as a tuple for now. Together with the change in this pull request it's now relatively readable and I also have no idea how we might expand it in the future. We can defer that decision. So I would suggest to merge it as is for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is easier to understand what's going on in the From logic for ProcessItem if the tuple fields have named values.
Alternatively, we could consider to convert this to a struct. I personally would prefer that, but it's definitely a matter of preference and I don't have a strong opinion on it. ;)